Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.64] Fix publish builds by removing workspace from package.json before publish #866

Merged
merged 9 commits into from
Oct 28, 2021
Merged

[0.64] Fix publish builds by removing workspace from package.json before publish #866

merged 9 commits into from
Oct 28, 2021

Conversation

acoates-ms
Copy link
Collaborator

@acoates-ms acoates-ms commented Oct 26, 2021 •
edited
Loading

mganandraj and others added 4 commits October 22, 2021 11:08
@mganandraj
Some more changes for bringing up RN64 in devmain Android (facebook#861)
8960e85 
* Build & Packaging changes for bringing up RN64 in devmain

* Fixing gradle clean

* Disable gradle clean in PR builds
@msgharpu
Fix for submit button disappearing bug in comments (facebook#862)
f9f7f8d 
* Add the missing android folder to files in package.json

* Fix for submit button disappear bug in comments

Co-authored-by: Mayuresh Gharpure <[email protected]>
@tido64
fix: ensure scripts always have Unix newlines (facebook#860)
78a879c
@acoates-ms
Fix for publishing from stable branches
952f43a
@pull-bot
Copy link

pull-bot commented Oct 26, 2021 •
edited
Loading

Warnings
⚠️

❔ Base Branch - The base branch for this PR is something other than master. Are you sure you want to merge these changes into a stable release? If you are interested in backporting updates to an older release, the suggested approach is to land those changes on master first and then cherry-pick the commits into the branch for that release. The Releases Guide has more information.
Messages
📖

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
📖 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.
📖 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.

Generated by 🚫 dangerJS against 16e3a84

@acoates-ms acoates-ms changed the title Bring in latest changes from master, and also #865 Fix publish builds by removing workspace from package.json before publish Oct 27, 2021
@acoates-ms acoates-ms changed the title Fix publish builds by removing workspace from package.json before publish [0.64] Fix publish builds by removing workspace from package.json before publish Oct 28, 2021
@acoates-ms acoates-ms mentioned this pull request Oct 28, 2021
Closed
4 tasks
@acoates-ms acoates-ms merged commit 1dc7d83 into microsoft:0.64-stable Oct 28, 2021
@acoates-ms acoates-ms deleted the publishfix branch September 2, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HeyImChris HeyImChris HeyImChris approved these changes

@alloy alloy Awaiting requested review from alloy alloy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@acoates-ms @pull-bot @HeyImChris @mganandraj @msgharpu @tido64