Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

This change updates react dependencies #67

Merged
merged 2 commits into from
May 17, 2019

Conversation

BarinderGrewal
Copy link

@BarinderGrewal BarinderGrewal commented May 15, 2019

⚠️ Make sure you are targeting Microsoft/react-native for your PR ⚠️

(then delete these lines)

Please select one of the following

  • I am making a change required for Microsoft usage of react-native

Description of changes

These dependencies were updated in devmain in file "//depot/devmain/opensource/reactnative/OfficeISS/ReactAndroid/devmainJava/build.gradle", but as suggested by @tudorms these changes will be overwritten by sync scripts.
So updating these here.

Microsoft Reviewers: Open in CodeFlow

@pull-bot
Copy link

Warnings
⚠️

📋 Test Plan - This PR appears to be missing a Test Plan.

⚠️

📋 Release Notes - This PR appears to be missing Release Notes.

Generated by 🚫 dangerJS

@BarinderGrewal
Copy link
Author

@rojain is added to the review. #Closed

@acoates-ms
Copy link
Collaborator

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@BarinderGrewal
Copy link
Author

Hey @acoates-ms
Could you please approve these changes or suggest if something needs to be changed

@acoates-ms acoates-ms merged commit ae2677e into microsoft:master May 17, 2019
t-nanava pushed a commit that referenced this pull request Jun 17, 2019
* This change updates react dependencies

* Updating yarn.lock file
@BarinderGrewal BarinderGrewal deleted the UpdateReactDeps branch July 19, 2019 11:15
NickGerleman pushed a commit to NickGerleman/react-native that referenced this pull request Jul 20, 2022
Summary:
X-link: facebookincubator/hsthrift#67

Updating `googletest` from `1.8.0` to `1.10.0`

Reviewed By: mzlee, igorsugak, luciang, meyering, r-barnes

Differential Revision: D34351084

fbshipit-source-id: 939b3985ab63a06b6d511ec8711c2d5863bdfea8
Saadnajmi pushed a commit to Saadnajmi/react-native-macos that referenced this pull request Jan 15, 2023
Summary:
X-link: facebookincubator/hsthrift#67

Updating `googletest` from `1.8.0` to `1.10.0`

Reviewed By: mzlee, igorsugak, luciang, meyering, r-barnes

Differential Revision: D34351084

fbshipit-source-id: 939b3985ab63a06b6d511ec8711c2d5863bdfea8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants