[0.71] Re-enable direct debugging with JSC on latest OS versions #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saadnajmi
changed the title
harrieshin
approved these changes
Jun 14, 2023
harrieshin
reviewed
Jun 21, 2023
| @@ -396,6 +396,13 @@ JSCRuntime::JSCRuntime(JSGlobalContextRef ctx) | |||
| stringCounter_(0) | |||
| #endif | |||
| { | |||
| // [macOS | |||
| #ifndef NDEBUG | |||
There was a problem hiding this comment.
ifndef is evil because even setting to =0 means it defines it and so dumb people like me get confused why things are compiling and then duh moment.
|
Closing this PR, plan is to pick to upstream 0.71 and then get it in our next merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #1848 to 0.71-stable