Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable direct debugging with JSC on latest OS versions #1848

Merged
merged 3 commits into from
Aug 29, 2023

Commits on Aug 23, 2023

  1. Re-enable direct debugging with JSC on iOS 16.4+ (facebook#37914)

    Summary:
    Pull Request resolved: facebook#37914
    
    Restores facebook#37874 (reverted earlier today), with fix for `JSCRuntime.cpp` build on Android.
    
    Changelog: None
    
    Reviewed By: cortinico
    
    Differential Revision: D46762984
    
    fbshipit-source-id: 6d56f81b9d0c928887860993b2b729ed96c0734c
    huntie authored and Saadnajmi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    bfe4282 View commit details
    Browse the repository at this point in the history
  2. Guard JSGlobalContextSetInspectable behind a compile time check for…

    … Xcode 14.3+ (facebook#39037)
    
    Summary:
    An earlier [change](facebook@8b1bf05) I made (that huntie resubmitted) only works on Xcode 14.3+ (See more info [here](react-native-community/discussions-and-proposals#687)). This change adds the appropriate compiler checks so that the change is compatible with Xcode 14.2 and earlier, and therefore cherry-pickable to 0.71 and 0.72.
    
    The check works by checking if iOS 16.4+ is defined, which is the closest proxy I could find for "Is this Xcode 14.3".
    
    ## Changelog:
    
    [IOS] [CHANGED] - Guard `JSGlobalContextSetInspectable` behind a compile time check for Xcode 14.3+
    
    Pull Request resolved: facebook#39037
    
    Test Plan: I can't actually test on Xcode 14.2 (it won't launch on my MacBook 😢), but I made a similar [PR](microsoft#1848) in React Native macOS, whose CI checks run against Xcode 14.2 and I'm getting passing checks there.
    
    Reviewed By: huntie
    
    Differential Revision: D48414196
    
    Pulled By: NickGerleman
    
    fbshipit-source-id: ba10a6505dd11d982cc56c02bf9f7dcdc104bbec
    Saadnajmi committed Aug 23, 2023
    Configuration menu
    Copy the full SHA
    3c99afe View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2023

  1. Configuration menu
    Copy the full SHA
    05e7dc3 View commit details
    Browse the repository at this point in the history