Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[0.71] Make sure the Native RuntimeScheduler is initialized on Old Arch #1835

Closed
wants to merge 3 commits into from
Closed

[0.71] Make sure the Native RuntimeScheduler is initialized on Old Arch #1835

wants to merge 3 commits into from

Conversation

Saadnajmi
Copy link
Collaborator

This is a working branch to test changes of this change back ported to 0.71:

facebook#37523

sammy-SC and others added 2 commits May 30, 2023 14:40
@sammy-SC @Saadnajmi
Enable RuntimeScheduler in old architecture (facebook#37523)
2c256b1 
Summary:

[IOS] [FIXED] - unexpected useEffects flushing semantics

Pull Request resolved: facebook#37523

Test Plan: Run RNTester with old architecture and make sure RuntimeScheduler is used.

Reviewed By: cipolleschi

Differential Revision: D46078324

Pulled By: sammy-SC

fbshipit-source-id: 5f18cbe60e6c9c753c373f175ba413b79288a928
@Saadnajmi
WIP
ea9c50c
@Saadnajmi Saadnajmi requested a review from a team as a code owner May 31, 2023 05:27
@Saadnajmi Saadnajmi marked this pull request as draft May 31, 2023 05:28
@Saadnajmi Saadnajmi changed the base branch from main to 0.71-stable May 31, 2023 05:28
@github-actions
Copy link

Fails
🚫

📋 Missing Changelog - Can you add a Changelog? To do so, add a "## Changelog" section to your PR description. A changelog entry has the following format: [CATEGORY] [TYPE] - Message.

CATEGORY may be:
  • General
  • macOS
  • iOS
  • Android
  • JavaScript
  • Internal (for changes that do not need to be called out in the release notes)

TYPE may be:

  • Added, for new features.
  • Changed, for changes in existing functionality.
  • Deprecated, for soon-to-be removed features.
  • Removed, for now removed features.
  • Fixed, for any bug fixes.
  • Security, in case of vulnerabilities.

MESSAGE may answer "what and why" on a feature level. Use this to briefly tell React Native users about notable changes.
Warnings
⚠️ 📋 Missing Summary - Can you add a Summary? To do so, add a "## Summary" section to your PR description. This is a good place to explain the motivation for making this change.
⚠️ 🔒 package.json - Changes were made to package.json. This will require a manual import by a Facebook employee.
⚠️ 📋 Missing Test Plan - Can you add a Test Plan? To do so, add a "## Test Plan" section to your PR description. A Test Plan lets us know how these changes were tested.

Generated by 🚫 dangerJS against ea9c50c

@Saadnajmi Saadnajmi changed the title Hotfix 71 [0.71] Make sure the Native RuntimeScheduler is initialized on Old Arch May 31, 2023
@Saadnajmi Saadnajmi closed this Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Pick Request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Saadnajmi @sammy-SC