Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-pick: Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS (#35131) #1466

Merged

Conversation

christophpurrer
Copy link

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

Pull Request resolved: facebook#35131

Changelog

[macOS][Fixed] - Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS

Test Plan

Not used for macOS
Would not work on macOS

rn-iOS + Fabric still works:

…ich breaks macOS (facebook#35131)

Summary:
Pull Request resolved: facebook#35131

Changelog:
[iOS][Fixed] - Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS

Reviewed By: cortinico

Differential Revision: D40797971

fbshipit-source-id: 29839913a642247576caba9fe34724129c2bd3ba
@christophpurrer christophpurrer requested a review from a team as a code owner November 3, 2022 11:57
@christophpurrer christophpurrer changed the title Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS (#35131) Cherry-pick: Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS (#35131) Nov 3, 2022
@Saadnajmi Saadnajmi merged commit e976cac into microsoft:main Nov 10, 2022
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Feb 13, 2023
…ich breaks macOS (facebook#35131) (microsoft#1466)

Summary:
Pull Request resolved: facebook#35131

Changelog:
[iOS][Fixed] - Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS

Reviewed By: cortinico

Differential Revision: D40797971

fbshipit-source-id: 29839913a642247576caba9fe34724129c2bd3ba
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
…ich breaks macOS (facebook#35131) (microsoft#1466)

Summary:
Pull Request resolved: facebook#35131

Changelog:
[iOS][Fixed] - Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS

Reviewed By: cortinico

Differential Revision: D40797971

fbshipit-source-id: 29839913a642247576caba9fe34724129c2bd3ba
shwanton pushed a commit to shwanton/react-native-macos that referenced this pull request Mar 10, 2023
…ich breaks macOS (facebook#35131) (microsoft#1466)

Summary:
Pull Request resolved: facebook#35131

Changelog:
[iOS][Fixed] - Remove unused #import <UIKit/UIGestureRecognizerSubclass.h> import which breaks macOS

Reviewed By: cortinico

Differential Revision: D40797971

fbshipit-source-id: 29839913a642247576caba9fe34724129c2bd3ba
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

2 participants