Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old versions of string_decoder #1261

Merged
merged 2 commits into from
Jul 19, 2022

Conversation

amgleitman
Copy link
Member

Please select one of the following

  • I am removing an existing difference between facebook/react-native and microsoft/react-native-macos 👍
  • I am cherry-picking a change from Facebook's react-native into microsoft/react-native-macos 👍
  • I am making a fix / change for the macOS implementation of react-native
  • I am making a change required for Microsoft usage of react-native

Summary

We're still holding on to an old version of string_decoder in some places. We get rid of them by doing the following:

  • For the one in bots/, we have this dependency because of firebase, and even the latest version of firebase depends on the old string_decoder, so the solution here is to resolve readable-stream (the module that actually pulls in string_decoder) to at least 4.0.0 (similar to what we had to do in Resolve readable-stream to 4.0.0 #1252).
  • For the one in ReactCommon/hermes/inspector/tools/msggen/, we just need to upgrade webpack to the latest version and we're all set.

@amgleitman amgleitman requested a review from a team as a code owner July 18, 2022 22:05
@amgleitman
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amgleitman
Copy link
Member Author

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@amgleitman amgleitman merged commit 573eab0 into microsoft:main Jul 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants