Remove old versions of string_decoder
#1261
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please select one of the following
Summary
We're still holding on to an old version of
string_decoder
in some places. We get rid of them by doing the following:bots/
, we have this dependency because offirebase
, and even the latest version offirebase
depends on the oldstring_decoder
, so the solution here is to resolvereadable-stream
(the module that actually pulls instring_decoder
) to at least 4.0.0 (similar to what we had to do in Resolve readable-stream to 4.0.0 #1252).ReactCommon/hermes/inspector/tools/msggen/
, we just need to upgradewebpack
to the latest version and we're all set.