Skip to content

Commit

Permalink
Remove Node 10 check (facebook#21001)
Browse files Browse the repository at this point in the history
Summary:
This script is not yet used. Regardless, Node 10 has been working fine for a while now.
Pull Request resolved: facebook#21001

Differential Revision: D9721549

Pulled By: hramos

fbshipit-source-id: 44b5e2f9ec9b622a364491840f8bd8092f0399ff
  • Loading branch information
hramos authored and facebook-github-bot committed Sep 7, 2018
1 parent 435c6ba commit 5717e52
Showing 1 changed file with 1 addition and 8 deletions.
9 changes: 1 addition & 8 deletions scripts/validate-ios-test-env.sh
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# testing environment.
#
# In particular, it checks that the minimum required Xcode version is installed.
# It also checks that the correct Node version is installed. Node 10 is not fully
# It also checks that the correct Node version is installed. Node 10 is not fully
# supported at the time and Node 6 is no longer supported.

# Function used to compare dot seperated version numbers
Expand All @@ -22,17 +22,10 @@ NODE_VERSION="$(command node --version | sed 's/[-/a-zA-Z]//g' |sed 's/.\{2\}$//

if (( $(echo "${NODE_VERSION} <= 6.0" | bc -l) )); then
echo "Node ${NODE_VERSION} detected. This version of Node is not supported."
echo "Note: Node 10 is not fully supported at the time and Node 6 is no longer supported."
echo "See https://nodejs.org/en/download/ for instructions."
exit 1
fi

if (( $(echo "${NODE_VERSION} == 10.0" | bc -l) )); then
echo "Node ${NODE_VERSION} detected. This version of Node is not fully supported at this time."
echo "See https://github.com/facebook/react-native/issues/19229 for more information."
exit 1
fi

# Check that Xcode is installed.
if [ -z "$(which xcodebuild)" ]; then
echo "Could not find Xcode build tools. Please check your Xcode install."
Expand Down

0 comments on commit 5717e52

Please sign in to comment.