Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Staging build: 'CodePush/CodePush.h' file not found #688

Closed
Amurmurmur opened this issue Feb 4, 2017 · 14 comments
Closed

Staging build: 'CodePush/CodePush.h' file not found #688

Amurmurmur opened this issue Feb 4, 2017 · 14 comments
Assignees

Comments

@Amurmurmur
Copy link

  • react-native-code-push version: 1.17.0-beta
  • react-native version: 0.41
  • iOS/Android/Windows version: iOS 10.2
  • Does this reproduce on a debug build or release build? Staging build
  • Does this reproduce on a simulator, or only on a physical device? Doesnt even build the project
  • Repro steps and/or stack trace:

Followed instructions exactly, for multi deployment (https://github.com/Microsoft/react-native-code-push#ios)

Problem only happens when trying to build Staging.
AppDelegate.m:11:9: 'CodePush/CodePush.h' file not found

@sergey-akhalkov sergey-akhalkov self-assigned this Feb 6, 2017
@sergey-akhalkov
Copy link
Contributor

@Amurmurmur, I've got the same issue and resolved it like this:
image
So I've changed Staging Build Products Path value from $(BUILD_DIR)/$(CONFIGURATION)$(EFFECTIVE_PLATFORM_NAME) to $(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME)
Could you please verify if it works for you? If so, we should probably update the documentation to workaround the issue.

@Amurmurmur
Copy link
Author

@sergey-akhalkov Yep that worked!! Thank you so much.
However I guess its just a workaround and the team has to fix it anyway, or add this in the documentation?!

Cheeers

@sergey-akhalkov
Copy link
Contributor

@Amurmurmur, thanks for the response. I've reproduced and fixed the issue in the same way without using CodePush. So initial react-native app (created by react-native init myapp command) also has this issue, we should probably investigate it to find more suitable solution or at least update the documentation.

@sergey-akhalkov
Copy link
Contributor

Closing this, please feel free to reopen if needed

@almadsen
Copy link

almadsen commented Feb 7, 2017

I was still getting this, my work around for it was/is:

skarmavbild 2017-02-08 kl 00 54 10

I first tried putting the search link in the target but that still got me a file not found, but in the project part it stoped giving me the error.

@Amurmurmur
Copy link
Author

@almadsen That didnt work for me :/ Only the solution suggested by @sergey-akhalkov did work. :/

sergey-akhalkov added a commit that referenced this issue Feb 9, 2017
After RN 0.40 it is not possible to use other configurations than Debug and Release (facebook/react-native#11813)
As workaround we could make Staging’s Build Products Path value the same as for Release configuration.

Fix #688
@SamMatthewsIsACommonName
Copy link

SamMatthewsIsACommonName commented Feb 20, 2017

Hi @sergey-akhalkov I'm having this issue but I don't think I have any 'multi deployment testing' setup, it's just when I go to run the release scheme. i've tried all solutions i.e manually importing codepush.h, adding the library from scratch etc. I'm running react native 0.40.0 and react-native-code-push 1.16.1-beta. The weird thing was it was working fine and I'd created a build and submitted it to the app store, but then I changed a google services.plist file and suddenly the build broke... I've tried restarting computer etc etc... Also in your solution above I can't actually find the 'Build Locations' settings anywhere, I'm using xcode 8.2

EDIT: Sorry was using wrong version, needed 1.17.1-beta

@neopit
Copy link

neopit commented Mar 30, 2017

I have a similar error but now with a POD.

The trick with $(BUILD_DIR)/Release$(EFFECTIVE_PLATFORM_NAME) seems to work but when there is a dependency that does not work anymore in particularly with GoogleToolboxForMac.

I tried to make some change on the PODS_CONFIGURATION_BUILD_DIR with the value $PODS_BUILD_DIR/Release$(EFFECTIVE_PLATFORM_NAME) but that does not work !

Someone as a solution when we use a POD ?

@salujaharkirat
Copy link

salujaharkirat commented Jun 19, 2017

@neopit not working with Pods on staging.. tried a lot

@xxsnakerxx
Copy link

Try to add Staging configuration to CodePush and React projects... works for me

@wprater
Copy link

wprater commented Nov 19, 2017

This issue is persisting for me when I try to build on Buddy Build or MMC App Center. anyone else encounter this?

@ekzn
Copy link

ekzn commented Apr 9, 2018

@sergey-akhalkov Thanks man it works

@baotoan1905
Copy link

baotoan1905 commented Jan 6, 2020

I can't find "Build Location -> Per-configuration Build Products Path". Any idea ?

@byteab
Copy link

byteab commented Oct 10, 2020

this issue still exist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests