-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Include completions for items from the same file; Clean up completions generation for callables #1863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
requested review from
billti,
idavis,
minestarks and
ScottCarda-MS
as code owners
August 20, 2024 01:41
Benchmark for 770b5c1Click to view benchmark
|
swernli
reviewed
Aug 20, 2024
swernli
approved these changes
Aug 20, 2024
Benchmark for ddc3954Click to view benchmark
|
billti
reviewed
Aug 20, 2024
billti
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes #1862.
I had previously touched this function in #1820. I did my best to port it and maintain existing functionality, but there was one conditional that I messed up, and it was around callables originating from the same file.
This PR fixes the bug that caused. But also, this PR tries to simplify
callable_decl_to_completion_item
so this is less likely to happen in the future.