-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port signed integer math to modern QDK #1841
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sezna
requested review from
cesarzc,
DmitryVasilevsky and
swernli
as code owners
August 14, 2024 02:31
Benchmark for 9bf065eClick to view benchmark
|
Benchmark for e9ecf1cClick to view benchmark
|
Benchmark for 45e2c36Click to view benchmark
|
Benchmark for 170b917Click to view benchmark
|
Benchmark for 75a9a1bClick to view benchmark
|
Benchmark for 03a5d55Click to view benchmark
|
Benchmark for 072b2feClick to view benchmark
|
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
reviewed
Aug 21, 2024
cesarzc
approved these changes
Aug 21, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few minor comments.
Co-authored-by: César Zaragoza Cortés <[email protected]>
Benchmark for 36e7798Click to view benchmark
|
Benchmark for b38992aClick to view benchmark
|
@sezna , Feel free to postpone all my comments for later time if you need. We can always improve code :) |
DmitryVasilevsky
approved these changes
Aug 22, 2024
Benchmark for 5bbb91aClick to view benchmark
|
Benchmark for 91aeb81Click to view benchmark
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ports the classic QDK's signed int math functionality to the modern QDK.
It is not intended to provide the perfect API -- it is just a port, that other libraries will build upon, primarily the fixed point library.