Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implicit Namespace Parsing Recovery #1808

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

ScottCarda-MS
Copy link
Contributor

@ScottCarda-MS ScottCarda-MS commented Jul 31, 2024

Fixes an issue where implicit namespace parsing would not recover after incomplete items. This is fixed by adding the end-of-file character as a recovery token.

Fixes #1794

@ScottCarda-MS ScottCarda-MS marked this pull request as ready for review July 31, 2024 19:22
Copy link

Benchmark for ba6e6cf

Click to view benchmark
Test Base PR %
Array append evaluation 336.4±4.84µs 339.5±6.70µs +0.92%
Array literal evaluation 194.6±4.08µs 174.8±1.21µs -10.17%
Array update evaluation 413.2±14.35µs 416.3±2.06µs +0.75%
Core + Standard library compilation 22.1±0.56ms 22.4±0.97ms +1.36%
Deutsch-Jozsa evaluation 4.9±0.05ms 5.0±0.07ms +2.04%
Large file parity evaluation 34.0±0.10ms 34.1±0.25ms +0.29%
Large input file compilation 13.4±0.42ms 13.4±0.59ms 0.00%
Large input file compilation (interpreter) 53.0±2.27ms 52.2±1.69ms -1.51%
Large nested iteration 32.4±0.37ms 33.0±0.39ms +1.85%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1572.0±45.99µs 1585.4±96.60µs +0.85%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.11ms 7.8±0.09ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1432.0±47.93µs 1454.5±119.82µs +1.57%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 27.9±0.25ms 28.1±0.38ms +0.72%
Teleport evaluation 91.7±5.68µs 93.5±4.13µs +1.96%

@ScottCarda-MS ScottCarda-MS added this pull request to the merge queue Aug 1, 2024
Merged via the queue into main with commit b67c746 Aug 1, 2024
21 checks passed
@ScottCarda-MS ScottCarda-MS deleted the sccarda/ImplicitNamespaceParse branch August 1, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Syntax error highlights valid code instead of invalid one when namespace is omitted
3 participants