Avoid spurious errors in Q# git diffs #1754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change updates the logic in `isQsharpDocument` to make sure the language service doesn't generate spurious errors from treating the left-hand side of the diff as a Q# file.
swernli
requested review from
billti,
idavis,
minestarks and
sezna
as code owners
Benchmark for 82e61ceClick to view benchmark
|
sezna
approved these changes
Jul 19, 2024
billti
reviewed
Jul 19, 2024
billti
approved these changes
Jul 19, 2024
swernli
added a commit
that referenced
this pull request
Aug 21, 2024
Much like git diffs with scheme `git`, viewing files surfaced from GitHub Pull Requests that come from a branch not currently checked out produces spurious errors since they are not real files on disk and have extra data in their filenames. This uses the same strategy as in #1754 to avoid them by not loading things with the custom `pr` URI scheme.
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 21, 2024
Much like git diffs with scheme `git`, viewing files surfaced from GitHub Pull Requests that come from a branch not currently checked out produces spurious errors since they are not real files on disk and have extra data in their filenames. This uses the same strategy as in #1754 to avoid them by not loading things with the custom `pr` URI scheme.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change updates the logic in
isQsharpDocumentto make sure the language service doesn't generate spurious errors from treating the left-hand side of the diff as a Q# file.