Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate tasks 6-10 from MarkingOracles Kata #1626

Merged
merged 26 commits into from
Jun 12, 2024
Merged

Migrate tasks 6-10 from MarkingOracles Kata #1626

merged 26 commits into from
Jun 12, 2024

Conversation

jkingdon-ms
Copy link
Contributor

@jkingdon-ms jkingdon-ms commented Jun 10, 2024 •
edited
Loading

This resolves part of #1185 .

@jkingdon-ms jkingdon-ms marked this pull request as ready for review June 12, 2024 01:30
tcNickolas
tcNickolas requested changes Jun 12, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I left some comments, mostly on rearranging the code so that all operations are in the most logical places for them, and one on majority task.

Thank you!

katas/content/marking_oracles/index.md Outdated Show resolved Hide resolved
katas/content/marking_oracles/index.md Outdated Show resolved Hide resolved
katas/content/marking_oracles/index.md Outdated Show resolved Hide resolved
katas/content/marking_oracles/index.md Outdated Show resolved Hide resolved
katas/content/marking_oracles/index.md Outdated Show resolved Hide resolved
katas/content/marking_oracles/majority/index.md Outdated Show resolved Hide resolved
katas/content/marking_oracles/majority/index.md Outdated Show resolved Hide resolved
katas/content/marking_oracles/num_div_3/Placeholder.qs Outdated Show resolved Hide resolved
katas/content/marking_oracles/num_div_3/Solution.qs Outdated Show resolved Hide resolved
katas/content/marking_oracles/num_div_3/index.md Outdated Show resolved Hide resolved
jkingdon-ms and others added 10 commits June 12, 2024 16:06
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/index.md
737de30 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/index.md
17a2e71 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/index.md
73e5007 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/index.md
2bcb350 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/index.md
d2f607c 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/majority/index.md
a1896c9 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/balanced/index.md
f10bfb0 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/bit_sum_div_3/index.md
b71f525 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/majority/index.md
1023fb0 
Co-authored-by: Mariia Mykhailova <[email protected]>
@jkingdon-ms @tcNickolas
Update katas/content/marking_oracles/num_div_3/index.md
e76579b 
Co-authored-by: Mariia Mykhailova <[email protected]>
tcNickolas
tcNickolas approved these changes Jun 12, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thank you so much for working on this!

@tcNickolas tcNickolas added this pull request to the merge queue Jun 12, 2024
Merged via the queue into microsoft:main with commit 7767519 Jun 12, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcNickolas tcNickolas tcNickolas approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc cesarzc is a code owner

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna sezna is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkingdon-ms @tcNickolas