Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Respect target setting for "Estimate" command #1576

Merged
merged 1 commit into from
May 28, 2024

Conversation

swernli
Copy link
Collaborator

@swernli swernli commented May 28, 2024

Fixes #1199.

Copy link

Benchmark for 56f24da

Click to view benchmark
Test Base PR %
Array append evaluation 329.0±1.78µs 335.0±3.53µs +1.82%
Array literal evaluation 178.4±3.65µs 177.1±1.16µs -0.73%
Array update evaluation 412.0±5.70µs 415.0±3.05µs +0.73%
Core + Standard library compilation 18.7±0.14ms 18.7±0.21ms 0.00%
Deutsch-Jozsa evaluation 5.2±0.06ms 5.2±0.07ms 0.00%
Large file parity evaluation 34.2±0.23ms 34.2±0.65ms 0.00%
Large input file compilation 12.4±0.11ms 12.7±0.15ms +2.42%
Large input file compilation (interpreter) 46.5±0.77ms 47.4±1.89ms +1.94%
Large nested iteration 32.8±1.12ms 32.7±0.31ms -0.30%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1569.1±47.01µs 1562.8±37.10µs -0.40%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.09ms 7.8±0.09ms 0.00%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1436.1±103.97µs 1419.9±32.86µs -1.13%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 28.6±0.26ms 28.7±0.17ms +0.35%
Teleport evaluation 90.7±4.45µs 89.7±3.54µs -1.10%

Copy link
Contributor

@sezna sezna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left one question, otherwise LGTM

@swernli swernli changed the title Repsect target setting for "Estimate" command Respect target setting for "Estimate" command May 28, 2024
@swernli swernli added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit d0346c4 May 28, 2024
16 checks passed
@swernli swernli deleted the swernli/use-target-for-estimate branch May 28, 2024 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resource Estimation does not respect current target setting
2 participants