Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tasks 1.5-1.9,1.11 to Distinguishing Unitaries Kata #1572

Merged
merged 49 commits into from
May 30, 2024

Conversation

jkingdon-ms
Copy link
Contributor

This resolves part of #1185 .

James Kingdon and others added 19 commits March 26, 2024 17:12
@jkingdon-ms jkingdon-ms marked this pull request as ready for review May 28, 2024 18:35
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work (and a lot of it too)!! I left some comments but they're mostly formatting/readability improvements.

I also realized that I was too optimistic about removing "from" from the operation names in the first four tasks - once we get to "distinguishing Y from XZ", that convention falls apart... Would you mind going back to the first four tasks and adding "from" to the titles too, so that operation names are uniform across the whole kata?

Thank you!!

katas/content/distinguishing_unitaries/index.md Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/index.md Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/index.md Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/z_mz/Solution.qs Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/z_mz/solution.md Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/rz_ry/index.md Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/rz_ry/Solution.qs Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/i_x_y_z/solution.md Outdated Show resolved Hide resolved
katas/content/distinguishing_unitaries/i_x_y_z/solution.md Outdated Show resolved Hide resolved
James Kingdon and others added 20 commits May 30, 2024 10:20
This reverts commit ce2c3d6.
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I verified that the changes to the unpublished kata build and pass the tests locally, so we can merge (and we'll re-run all tests in the PR that publishes it).

Thank you!

Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I missed one unresolved conversation that shows as outdated because of another change in that file: https://github.com/microsoft/qsharp/pull/1572/files/1268f8e311cc0fde90de3a75157eb1dce53d99e9#r1619438948 , to add a reminder of Rz and R1 gates to the description of that task rather than to its solution, same as we did for Rz and Ry in a later task.

Can you please do that final fix before merging this? Thank you!

@tcNickolas tcNickolas changed the title Add tasks 1.5,1.6,1.7,1.8,1.9,1.11 to Distinguishing Unitaries Kata Add tasks 1.5-1.9,1.11 to Distinguishing Unitaries Kata May 30, 2024
@tcNickolas tcNickolas enabled auto-merge May 30, 2024 19:06
@tcNickolas tcNickolas added this pull request to the merge queue May 30, 2024
Merged via the queue into microsoft:main with commit c48e4e9 May 30, 2024
16 checks passed
@jkingdon-ms jkingdon-ms deleted the katas/du-15-16-17-18-19-111 branch June 3, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants