Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Superposition task 2.4 #1411

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Add Superposition task 2.4 #1411

merged 12 commits into from
Apr 25, 2024

Conversation

frtibble
Copy link
Contributor

Part of #1185

frtibble
frtibble commented Apr 23, 2024
View reviewed changes
katas/content/index.json Outdated Show resolved Hide resolved
@frtibble frtibble marked this pull request as ready for review April 23, 2024 10:16
@frtibble
Copy link
Contributor Author

Thank you for your review comments @Manvi-Agrawal, have pushed some changes which should address those!

tcNickolas
tcNickolas requested changes Apr 24, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is shaping up well, but there are quite a few formatting issues. Do you build the playground locally? Seeing the new task built should help find them before code review. Please let us know if you ran into any issues with using the playground locally!

Thank you!

katas/content/superposition/three_states_two_qubits_phases/Placeholder.qs Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/Placeholder.qs Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/Solution.qs Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/Solution.qs Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/Verification.qs Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/index.md Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/Solution.qs Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/Solution.qs Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/solution.md Outdated Show resolved Hide resolved
katas/content/superposition/three_states_two_qubits_phases/solution.md Outdated Show resolved Hide resolved
tcNickolas
tcNickolas approved these changes Apr 25, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just left one tiny suggestion on partial application.

Thank you!

katas/content/superposition/three_states_two_qubits_phases/Verification.qs Outdated Show resolved Hide resolved
@tcNickolas tcNickolas added this pull request to the merge queue Apr 25, 2024
Merged via the queue into microsoft:main with commit ffa8299 Apr 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tcNickolas tcNickolas tcNickolas approved these changes

@Manvi-Agrawal Manvi-Agrawal Manvi-Agrawal left review comments

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc cesarzc is a code owner

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna sezna is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frtibble @tcNickolas @Manvi-Agrawal