Add CZ section and CNOT and CZ tasks to Multi-Qubit Gates kata #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WWhitedogi
requested review from
billti,
cesarzc,
DmitryVasilevsky,
sezna,
swernli and
tcNickolas
as code owners
Co-authored-by: Manvi-Agrawal <[email protected]>
Co-authored-by: Manvi-Agrawal <[email protected]>
Co-authored-by: Manvi-Agrawal <[email protected]>
Co-authored-by: Manvi-Agrawal <[email protected]>
Co-authored-by: Manvi-Agrawal <[email protected]>
1. Rename the Two Qubit Gates in order 1,2,3 2. Reorder the Two Qubit Gates1-3 3. Add a new section CZ gate
Updated the link.
tcNickolas
requested changes
Apr 20, 2024
There was a problem hiding this comment.
Looks good overall, and nice CZ lesson, that gate slipped our minds when we were creating the original tutorial!
I left some comments for tasks 2.1-2.3. Looking at the remaining tasks (for the next PR, not for this one, just saying this in case you work on the next one over the weekend),
- Let's call 2.4 "Amplitudes Swap" and add it as the third exercise in CNOT lesson
- 2.5 is good with current name, in the lesson Multi-controlled gates
- 2.6 is also good with current name, as the first exercise in the lesson Controlled Gates (before Controlled Rotation)
And those three should be tested as unitaries indeed, since they accept generic input states, not specific ones.
Thank you!
katas/content/multi_qubit_gates/two_qubit_gate_2/Placeholder.qs
Outdated
Show resolved
Hide resolved
katas/content/multi_qubit_gates/two_qubit_gate_2/Placeholder.qs
Outdated
Show resolved
Hide resolved
katas/content/multi_qubit_gates/two_qubit_gate_2/Verification.qs
Outdated
Show resolved
Hide resolved
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
Co-authored-by: Mariia Mykhailova <[email protected]>
|
tcNickolas
approved these changes
Apr 22, 2024
katas/content/multi_qubit_gates/relative_phase_minusone/Verification.qs
Outdated
Show resolved
Hide resolved
tcNickolas
changed the title
tcNickolas
changed the title
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.