Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tasks 1.11, 1.12 to Superposition Kata #1381

Merged
merged 10 commits into from
Apr 15, 2024
Merged

Add tasks 1.11, 1.12 to Superposition Kata #1381

merged 10 commits into from
Apr 15, 2024

Conversation

jkingdon-ms
Copy link
Contributor

This resolves part of #1185 .

tcNickolas
tcNickolas requested changes Apr 13, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a couple of suggestions on improving tests and formatting.

Thank you!

katas/content/superposition/zero_and_bitstring/Verification.qs Outdated Show resolved Hide resolved
katas/content/superposition/zero_and_bitstring/Verification.qs Outdated Show resolved Hide resolved
katas/content/superposition/two_bitstrings/Verification.qs Outdated Show resolved Hide resolved
katas/content/superposition/two_bitstrings/Verification.qs Outdated Show resolved Hide resolved
katas/content/superposition/two_bitstrings/solution.md Outdated Show resolved Hide resolved
katas/content/superposition/two_bitstrings/solution.md Outdated Show resolved Hide resolved
tcNickolas
tcNickolas approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@tcNickolas tcNickolas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just two minor comments (updated the links to the docs but forgot to update the function names themselves), I might be able to apply the suggestions myself.

Thank you!

katas/content/superposition/two_bitstrings/solution.md Outdated Show resolved Hide resolved
katas/content/superposition/two_bitstrings/solution.md Outdated Show resolved Hide resolved
@tcNickolas tcNickolas added this pull request to the merge queue Apr 15, 2024
Merged via the queue into microsoft:main with commit 39deb7b Apr 15, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frtibble frtibble frtibble left review comments

@tcNickolas tcNickolas tcNickolas approved these changes

@billti billti Awaiting requested review from billti billti is a code owner

@cesarzc cesarzc Awaiting requested review from cesarzc cesarzc is a code owner

@DmitryVasilevsky DmitryVasilevsky Awaiting requested review from DmitryVasilevsky DmitryVasilevsky is a code owner

@sezna sezna Awaiting requested review from sezna sezna is a code owner

@swernli swernli Awaiting requested review from swernli swernli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkingdon-ms @tcNickolas @frtibble