Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RIR remap block id pass #1353

Merged
merged 2 commits into from
Apr 2, 2024
Merged

RIR remap block id pass #1353

merged 2 commits into from
Apr 2, 2024

Conversation

swernli
Copy link
Collaborator

@swernli swernli commented Apr 2, 2024

This introduces a pass on RIR that takes the entry callable and remaps the block IDs such that they are sequentially ordered with a well-known pattern. This enables more efficient checks for later analysis passes.

This introduces a pass on RIR that takes the entry callable and remaps the block IDs such that they are sequentially ordered with a well-known pattern. This enables more efficient checks for later analysis passes.
@swernli swernli mentioned this pull request Apr 2, 2024
64 tasks
Copy link

github-actions bot commented Apr 2, 2024

Benchmark for 7ec0850

Click to view benchmark
Test Base PR %
Array append evaluation 340.4±3.49µs 365.2±2.92µs +7.29%
Array literal evaluation 173.5±0.79µs 193.2±1.33µs +11.35%
Array update evaluation 422.2±4.65µs 445.6±2.26µs +5.54%
Core + Standard library compilation 17.8±0.41ms 18.2±0.80ms +2.25%
Deutsch-Jozsa evaluation 5.1±0.06ms 5.2±0.07ms +1.96%
Large file parity evaluation 33.8±0.07ms 33.8±0.11ms 0.00%
Large input file compilation 12.0±0.49ms 11.7±0.30ms -2.50%
Large input file compilation (interpreter) 45.8±1.48ms 47.6±1.42ms +3.93%
Large nested iteration 33.2±0.19ms 35.9±0.12ms +8.13%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1500.6±37.55µs 1532.8±122.87µs +2.15%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.8±0.08ms 7.9±0.10ms +1.28%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1419.1±34.45µs 1429.3±62.53µs +0.72%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.2±0.21ms 21.8±0.59ms +2.83%
Teleport evaluation 83.8±6.68µs 85.8±5.34µs +2.39%

Copy link
Contributor

@cesarzc cesarzc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The implementation is surprisingly simple and readable!

Copy link

github-actions bot commented Apr 2, 2024

Benchmark for 493e885

Click to view benchmark
Test Base PR %
Array append evaluation 342.5±1.88µs 345.8±3.84µs +0.96%
Array literal evaluation 174.2±1.69µs 174.7±3.43µs +0.29%
Array update evaluation 426.9±1.20µs 427.5±2.59µs +0.14%
Core + Standard library compilation 19.6±0.65ms 20.9±0.79ms +6.63%
Deutsch-Jozsa evaluation 5.1±0.20ms 5.2±0.15ms +1.96%
Large file parity evaluation 33.7±0.09ms 33.8±0.20ms +0.30%
Large input file compilation 13.2±0.84ms 13.3±0.56ms +0.76%
Large input file compilation (interpreter) 50.9±2.14ms 50.5±2.22ms -0.79%
Large nested iteration 33.9±1.24ms 33.7±0.85ms -0.59%
Perform Runtime Capabilities Analysis (RCA) on Deutsch-Jozsa sample 1520.1±98.03µs 1533.6±113.87µs +0.89%
Perform Runtime Capabilities Analysis (RCA) on large file sample 7.9±0.16ms 8.1±0.15ms +2.53%
Perform Runtime Capabilities Analysis (RCA) on teleport sample 1440.4±87.93µs 1460.6±156.44µs +1.40%
Perform Runtime Capabilities Analysis (RCA) on the core and std libraries 21.6±0.46ms 22.6±0.68ms +4.63%
Teleport evaluation 82.3±7.61µs 82.7±3.52µs +0.49%

@swernli swernli added this pull request to the merge queue Apr 2, 2024
Merged via the queue into main with commit 2ed0ff8 Apr 2, 2024
16 checks passed
@swernli swernli deleted the swernli/remap-block-ids branch April 2, 2024 23:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants