Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Microsoft.Quantum.Measurement to compiler prelude #1233

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

eureka-cpu
Copy link
Contributor

Closes #1193

As suggested by @swernli, this PR adds Microsoft.Quantum.Measurement to the prelude to avoid constant importing.

@swernli
Copy link
Collaborator

swernli commented Mar 6, 2024

Hi @eureka-cpu , thanks for the contribution! As a way of updating the tests to depend on this change, could you also remove the instances of open Microsoft.Quantum.Measurement; from the following files:

  • compiler/qsc_codegen/src/qir_base/tests.rs
  • compiler/qsc_eval/src/tests.rs
  • library/src/tests/arithmetic.rs
  • library/src/tests/canon.rs
  • library/src/tests/measurement.rs
  • library/src/tests/resources/add_le.qs
  • library/src/tests/resources/compare.qs
  • library/src/tests/resources/inc_by_le.qs
  • library/src/tests/resources/select.qs
  • library/src/tests/resources/state_preparation.qs
  • library/std/internal.qs
  • library/std/unstable_table_lookup.qs
  • resource_estimator/src/counts/tests.rs

The reasoning for just that subset is that we don't want to remove the open directive from files that are part of public samples until this change makes it into a release.

@swernli swernli added this pull request to the merge queue Mar 13, 2024
Merged via the queue into microsoft:main with commit 5458bd0 Mar 13, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move MResetZ to Intrinsic namespace?
2 participants