Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double-factorized chemistry sample #1033

Merged
merged 6 commits into from
Jan 19, 2024
Merged

Add double-factorized chemistry sample #1033

merged 6 commits into from
Jan 19, 2024

Conversation

tcNickolas
Copy link
Member

No description provided.

Co-Authored-By: Mathias Soeken <[email protected]>
Co-Authored-By: Aarthi Sundaram <[email protected]>
Copy link

Benchmark for dbc91c0

Click to view benchmark
Test Base PR %
Array append evaluation 919.6±9.89µs 875.1±6.17µs -4.84%
Array update evaluation 991.2±4.66µs 950.5±17.02µs -4.11%
Deutsch-Jozsa evaluation 31.5±0.20ms 31.5±0.30ms 0.00%
Large file parity evaluation 36.2±0.08ms 36.4±0.29ms +0.55%
Large input file 38.5±0.75ms 38.8±1.21ms +0.78%
Standard library 21.0±0.20ms 20.9±0.22ms -0.48%
Teleport evaluation 106.4±1.95µs 108.5±8.03µs +1.97%

@swernli
Copy link
Collaborator

swernli commented Jan 18, 2024

The test failure is unfortunately expected, but @sezna is already working on a fix! There is automated logic that tries to build samples, but it doesn't know how to build multi-file projects yet.

Copy link
Member

@msoeken msoeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I left some comments.

samples/estimation/df-chemistry/README.md Outdated Show resolved Hide resolved
samples/estimation/df-chemistry/README.md Show resolved Hide resolved
samples/estimation/df-chemistry/chemistry.py Outdated Show resolved Hide resolved
samples/estimation/df-chemistry/chemistry.py Outdated Show resolved Hide resolved
samples/estimation/df-chemistry/chemistry.py Outdated Show resolved Hide resolved
samples/estimation/df-chemistry/chemistry.py Show resolved Hide resolved
samples/estimation/df-chemistry/chemistry.py Outdated Show resolved Hide resolved
samples/estimation/df-chemistry/chemistry.py Outdated Show resolved Hide resolved
samples/estimation/df-chemistry/src/df_chemistry.qs Outdated Show resolved Hide resolved
samples/estimation/df-chemistry/src/df_chemistry.qs Outdated Show resolved Hide resolved
Copy link

Benchmark for a7eb214

Click to view benchmark
Test Base PR %
Array append evaluation 870.4±9.51µs 876.8±9.27µs +0.74%
Array update evaluation 940.9±5.15µs 947.9±7.62µs +0.74%
Deutsch-Jozsa evaluation 31.2±0.19ms 31.3±0.39ms +0.32%
Large file parity evaluation 36.2±0.14ms 36.2±0.10ms 0.00%
Large input file 39.2±0.84ms 38.8±0.83ms -1.02%
Standard library 22.5±1.05ms 21.6±0.58ms -4.00%
Teleport evaluation 104.9±2.07µs 105.1±2.05µs +0.19%

Copy link

Benchmark for 9ed471c

Click to view benchmark
Test Base PR %
Array append evaluation 895.6±16.56µs 877.4±6.86µs -2.03%
Array update evaluation 965.5±10.93µs 943.0±7.16µs -2.33%
Deutsch-Jozsa evaluation 31.5±1.04ms 31.5±0.30ms 0.00%
Large file parity evaluation 36.4±0.43ms 36.7±0.76ms +0.82%
Large input file 42.7±1.18ms 42.2±1.56ms -1.17%
Standard library 22.5±0.40ms 22.4±0.49ms -0.44%
Teleport evaluation 104.3±1.73µs 107.5±1.84µs +3.07%

Copy link

Benchmark for f73c336

Click to view benchmark
Test Base PR %
Array append evaluation 871.3±8.11µs 862.9±7.38µs -0.96%
Array update evaluation 943.1±6.81µs 936.4±17.87µs -0.71%
Deutsch-Jozsa evaluation 31.6±0.22ms 31.5±0.24ms -0.32%
Large file parity evaluation 36.5±0.17ms 36.4±0.08ms -0.27%
Large input file 43.6±1.54ms 44.7±1.71ms +2.52%
Standard library 23.1±0.72ms 24.2±0.72ms +4.76%
Teleport evaluation 106.5±2.75µs 104.7±7.97µs -1.69%

Copy link
Member

@msoeken msoeken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All my comments have been addressed.

@sezna
Copy link
Contributor

sezna commented Jan 18, 2024

Once #1040 goes in, this multi-file sample should work.

Copy link

Benchmark for 79e65cc

Click to view benchmark
Test Base PR %
Array append evaluation 867.2±10.20µs 872.2±7.60µs +0.58%
Array update evaluation 940.5±16.39µs 952.0±45.15µs +1.22%
Deutsch-Jozsa evaluation 31.5±0.24ms 31.5±1.25ms 0.00%
Large file parity evaluation 36.1±0.11ms 36.1±1.19ms 0.00%
Large input file 39.2±0.82ms 39.3±1.47ms +0.26%
Standard library 21.0±0.26ms 21.0±0.31ms 0.00%
Teleport evaluation 105.6±1.68µs 103.8±1.60µs -1.70%

@swernli swernli added this pull request to the merge queue Jan 19, 2024
Merged via the queue into main with commit 6f4ae3a Jan 19, 2024
13 checks passed
@swernli swernli deleted the mariia/df-chemistry branch January 19, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants