This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Fix #914: Multiple fast opening of files causes GetAnalysisAsync to return old analysis #919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sync to return old analysis
| @@ -212,7 +212,7 @@ internal PythonModule(ModuleCreationOptions creationOptions, IServiceContainer s | |||
| lock (AnalysisLock) { | |||
| LoadContent(content, version); | |||
|
|
|||
| var startParse = ContentState < State.Parsing && _parsingTask == null; | |||
| var startParse = ContentState < State.Parsing && (_parsingTask == null || version > 0); | |||
MikhailArkhipov
approved these changes
Apr 10, 2019
jakebailey
pushed a commit
to jakebailey/python-language-server
that referenced
this pull request
Nov 1, 2019
…sync to return old analysis (microsoft#919) * Fix microsoft#914: Multiple fast opening of files causes GetAnalysisAsync to return old analysis * Disable out of order analysis for the cases when current session is small
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.