This repository has been archived by the owner on Apr 14, 2022. It is now read-only.
Fix modules reload leak #182
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -274,6 +274,7 @@ internal class AstPythonInterpreter : IPythonInterpreter2, IModuleContext, ICanF | |||
| } | |||
|
|
|||
| _analyzer = state; | |||
| RemoveImportedModules(); | |||
There was a problem hiding this comment.
Do we need a lock here?
There was a problem hiding this comment.
Code locks on _userSearchPathImported operations
There was a problem hiding this comment.
I am resolving it on another work with importing/search paths
| foreach (var mod in _modulesByFilename.Values) { | ||
| mod.Clear(); | ||
| mod.EnsureModuleVariables(this); | ||
| } | ||
|
|
||
| _interpreterFactory.NotifyImportNamesChanged(); |
There was a problem hiding this comment.
Who is listening to this ImportableModulesChanged event?
There was a problem hiding this comment.
AstFactory and AstIntepreter, erasing caches
added 11 commits
October 3, 2018 10:21
|
#209 first |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #109
Simplifies event listening and make things happen in proper order. Reloading modules no longer increases RAM.