Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement PEP 604 #659

Closed
erictraut opened this issue May 5, 2020 · 3 comments
Closed

Implement PEP 604 #659

erictraut opened this issue May 5, 2020 · 3 comments
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request

Comments

@erictraut
Copy link
Collaborator

https://www.python.org/dev/peps/pep-0604/
@erictraut erictraut added the enhancement request New feature or request label May 5, 2020
@jakebailey
Copy link
Member

And even before this is accepted and in 3.9, doing this in the tooltips would make things a lot easier to read (so much less nesting). Though I'm not sure how far the tooltips should diverge from the actual code you have to type out.

@erictraut
Copy link
Collaborator Author

I've implemented support for PEP 604, but I've left the tooltips to use the old Union[] and Optional[] notation for now. It's a two-line change if we decide to change it.

@erictraut erictraut added the addressed in next version Issue is fixed and will appear in next published version label May 6, 2020
@erictraut
Copy link
Collaborator Author

This is now implemented in version 1.1.36, which I just published.

@srittau srittau mentioned this issue Jan 6, 2021
Closed
10 tasks
heejaechang pushed a commit to heejaechang/pyright that referenced this issue Nov 3, 2021
@jakebailey
Move bundled-stubs and bundled-indices into common directory (microso…
efc100e 
…ft#659)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
addressed in next version Issue is fixed and will appear in next published version enhancement request New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jakebailey @erictraut