datalogger: Add CODAL flags to enable BLE service with extension. #5346
Conversation
microbit-carlos
force-pushed
the
datalog-ble
branch
2 times, most recently
from
3edf6d3 to
7edf7f3
Compare
microbit-carlos
force-pushed
the
datalog-ble
branch
from
7edf7f3 to
b2b7bed
Compare
|
I've rebased this branch and changed the flags workaround issue #5352. Test deployment: https://makecode.microbit.org/app/bb83e4999507cac72d1e23434c8d8f8bf73c8ef1-34e6ba055c @martinwork would you be able to test this with the app? Thanks! |
…o issue #5352. Due to issue #5352 the flags set up only for CODAL don't work correctly. The issue will be fixed in the future, but as a workaround we can set the flag for both DAL and CODAL, even if this is a V2 only feature. Also removes the user config switch, as it didn't work and we prefer having less options. The flag can always be manually changes in the pxt.json file.
microbit-carlos
force-pushed
the
datalog-ble
branch
from
b2b7bed to
b267b4d
Compare
|
@abchatra this has been tested by @martinwork and ready to be merged 👍 |
|
@riknoll can you review this change? |
|
Apologies for the rush, but ideally we'd like to have this release as soon as possible, to be able to access the datalog from the iOS app for a specific event. Would it be possible to prioritise this? Thank you! |
) * datalogger: Add CODAL flags to enable BLE service with extension. * datalogger: Change flags from CODAL-only to both DAL and CODAL, due to issue #5352. Due to issue #5352 the flags set up only for CODAL don't work correctly. The issue will be fixed in the future, but as a workaround we can set the flag for both DAL and CODAL, even if this is a V2 only feature. Also removes the user config switch, as it didn't work and we prefer having less options. The flag can always be manually changes in the pxt.json file.
|
I have released the fix to live. |
|
Thanks @abchatra, I appreciate it! |
This PR adds a couple of CODAL flags to the data logging extension, so that the Utility service is enabled when bluetooth is enabled. Similarly to the Events Service.
This Utility Service is used by the iOS app to fetch and display the data logging data in the app.
Test deployment:
Due to this issue this PR doesn't work, so setting as a draft PR until it is resolved:
pxt.jsonwithyotta.config.codaldoes not work #5352