reference new docker image in local build #5265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -196,7 +196,7 @@ | |||
| "githubCorePackage": "lancaster-university/microbit-v2-samples", | |||
| "gittag": "v0.2.12", | |||
| "serviceId": "mbcodal2", | |||
| "dockerImage": "pext/yotta:update-yotta3", | |||
| "dockerImage": "pext/yotta:latest", | |||
There was a problem hiding this comment.
Thanks @eanders-ms!
I though the V2 CODAL builds might still be using the docker image with the newest gcc version, which would be pext/yotta:update-yotta3 with gcc v7?
Is gcc v6 also producing smaller micro:bit V2 CODAL builds?
There was a problem hiding this comment.
Our compiler service is configured to build V2 CODAL using yotta:latest (gcc 6). I left that unchanged for the time being.
There was a problem hiding this comment.
Oh okay, from previous conversation I though MakeCode v5 stoped using pext/yotta:latest (gcc v6) and started using pext/yotta:update-yotta3 (gcc v7). Was that only for V1 DAL and V2 CODAL was left using the older docker image?
srietkerk
approved these changes
Jun 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @microbit-carlos