fix rate at which multiplayer images are sent to 20fps #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It felt like way too many messages were going through so I poked around for a bit, due to some pretty weird lifecycle stuff in simdriver we actually end up initializing multiple times (I didn't look too closely but it appears to be a bit of a race -- e.g. when I just logged out I saw upwards of 4-5 calls to init like this but when I set breakpoints I only saw it repeat once or so), and this setInterval was getting recreated multiple times and sending upwards of 100 frames / a second.
The frame sending logic is independent of the individual sim runtime either way, so limit to a single setInterval in the scope of the frame