Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

remove yield from CMD_RUN request #94

Merged
merged 1 commit into from
Feb 17, 2018
Merged

remove yield from CMD_RUN request #94

merged 1 commit into from
Feb 17, 2018

Conversation

DonJayamanne
Copy link
Contributor

Fixes #93

@int19h
Copy link
Contributor

int19h commented Feb 17, 2018

I'm curious - does it cause some issue, or is it simply redundant?

@karthiknadig
Copy link
Member

For VS, I never used to get the process event.

@DonJayamanne
Copy link
Contributor Author

DonJayamanne commented Feb 17, 2018 •
edited
Loading

I'm now using this to get the processid so I can kill the process when vscode sends the disconnect request.

@int19h
Copy link
Contributor

int19h commented Feb 17, 2018

Ah, I see, so it's not actually a request/response, but we treat it as one (and wait for a response that'll never come).

@karthiknadig karthiknadig merged commit c10e4d3 into microsoft:master Feb 17, 2018
@DonJayamanne
Copy link
Contributor Author

wait for a response that'll never come

Bingo

@fuzihaofzh fuzihaofzh mentioned this pull request Jul 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@karthiknadig karthiknadig karthiknadig approved these changes

@int19h int19h int19h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @int19h @karthiknadig