Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Ensure stackFrame and levels in stack request are optional #77

Merged
merged 2 commits into from
Feb 15, 2018
Merged

Ensure stackFrame and levels in stack request are optional #77

merged 2 commits into from
Feb 15, 2018

Conversation

DonJayamanne
Copy link
Contributor

Fixes #76

int19h
int19h reviewed Feb 15, 2018
View reviewed changes
ptvsd/wrapper.py Outdated
startFrame = int(args['startFrame'])
levels = int(args['levels'])

startFrame = int(args['startFrame']) if 'startFrame' in args else 0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

int(args.get('startFrame', 0))?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol, will do

@DonJayamanne
Copy link
Contributor Author

Lol

@DonJayamanne
Copy link
Contributor Author

@int19h fixed

@karthiknadig karthiknadig merged commit c6c8491 into microsoft:master Feb 15, 2018
@fuzihaofzh fuzihaofzh mentioned this pull request Jul 23, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@int19h int19h int19h left review comments

@karthiknadig karthiknadig karthiknadig approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DonJayamanne @int19h @karthiknadig