Add unhandled exception tests #682
Conversation
Codecov Report
@@ Coverage Diff @@
## master #682 +/- ##
==========================================
+ Coverage 60.18% 60.19% +0.01%
==========================================
Files 27 27
Lines 3823 3824 +1
==========================================
+ Hits 2301 2302 +1
Misses 1522 1522
Continue to review full report at Codecov.
|
|
@DonJayamanne I am running into timeouts on VSTS for windows for some of the tests. Not sure if this is because the timeout is too short for those tests. This does not repro when running locally. |
karthiknadig
changed the title
| @@ -258,22 +258,28 @@ def test_breaking_into_handled_exceptions(self): | |||
| DebugInfo(filename=filename, cwd=cwd)) | |||
|
|
|||
| def test_breaking_into_uncaught_exceptions(self): | |||
| DebugSessionConnection.VERBOSE = True | |||
| filename = TEST_FILES.resolve('unhandled_exceptions_launch.py') | |||
There was a problem hiding this comment.
This is something that should be done with a context manager (with)
There was a problem hiding this comment.
I won’t be using that. I added that temporarily to find a issue I was running into on Travis.
karthiknadig
changed the title
|
@DonJayamanne This is ready for review. |
ptvsd/wrapper.py
Outdated
| @@ -798,7 +799,7 @@ def _parse_debug_options(opts): | |||
| continue | |||
|
|
|||
| if 'CLIENT_OS_TYPE' not in options: | |||
| options['CLIENT_OS_TYPE'] = 'WINDOWS' if platform.system() == 'Windows' else 'UNIX' # noqa | |||
| options['CLIENT_OS_TYPE'] = 'WINDOWS' if platform.system() == 'Windows' else 'UNIX' # noqa | |||
There was a problem hiding this comment.
Linter issue, you need only one space before #
| 'breakMode': 'unhandled', | ||
| 'details': { | ||
| 'typeName': 'ValueError', | ||
| # 'source': debug_info.filename |
There was a problem hiding this comment.
Please enable testing of source
| 'breakMode': 'always', | ||
| 'details': { | ||
| 'typeName': 'ValueError', | ||
| # 'source': debug_info.filename |
There was a problem hiding this comment.
Please enable testing of source
| 'breakMode': 'always', | ||
| 'details': { | ||
| 'typeName': 'ValueError', | ||
| # 'source': debug_info.filename |
There was a problem hiding this comment.
Please enable testing of source
This PR does the following:
_io.pythat causedJSONDecodeErrorin tests sometimes Tests fail with Unterminated string starting at: line 1 column 90 (char 89) #683