Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Fix 72 break suspension policy #673

Merged
merged 2 commits into from
Jul 23, 2018

Conversation

fabioz
Copy link
Contributor

@fabioz fabioz commented Jul 17, 2018

Note: built upon #671 to avoid conflicts (so, that one has to be merged first).

Changes can be seen at commit: 5641357 (note that it has some test changes along to fix some flakiness on pydevd tests on travis).

@codecov-io
Copy link

codecov-io commented Jul 17, 2018

Codecov Report

Merging #673 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #673      +/-   ##
==========================================
+ Coverage   60.18%   60.19%   +0.01%     
==========================================
  Files          27       27              
  Lines        3823     3824       +1     
==========================================
+ Hits         2301     2302       +1     
  Misses       1522     1522
Impacted Files Coverage Δ
ptvsd/wrapper.py 52.78% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf83758...7145532. Read the comment docs.

@fabioz fabioz force-pushed the fix_72_break_suspension_policy branch from 5641357 to eeba4bc Compare July 18, 2018 17:16
@fabioz
Copy link
Contributor Author

fabioz commented Jul 18, 2018

Rebased with current master.

Note that this patch only adds the break suspension policy to breakpoints. Working on providing the stack trace of live threads.

@fabioz fabioz force-pushed the fix_72_break_suspension_policy branch from eeba4bc to 7145532 Compare July 19, 2018 14:05
@fabioz
Copy link
Contributor Author

fabioz commented Jul 19, 2018

This pull request is now ready to implement the feature to get the live stack traces.

Some other noteworthy changes:

  • pydevd frames are now also filtered no longer appear for the user
  • fixed racing condition regarding setting the pydevd thread id
  • in case of a test timeout in pydevd tests the current thread dump is displayed
  • remote debug threads allocate a new port to run
  • added some missing variable types for cython

@DonJayamanne
Copy link
Contributor

remote debug threads allocate a new port to run

What's this? Please could you explain this change/feature?

@fabioz
Copy link
Contributor Author

fabioz commented Jul 19, 2018

remote debug threads allocate a new port to run

What's this? Please could you explain this change/feature?

Sorry, I didn't explain it well... it should be:

  • Tests which check remote debugging use a new port to run the test.

(i.e.: it's an improvement only for pydevd tests).

Copy link
Member

@karthiknadig karthiknadig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@karthiknadig karthiknadig merged commit d997742 into microsoft:master Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants