Fix path mappings with remote debugging #624
Conversation
|
Tested this and it fixes the mapping issue. |
DonJayamanne
force-pushed
the
fixPathMappings
branch
from
b2cd7b4
to
ef49dd1
Compare
DonJayamanne
changed the title
|
The wrapper.py change looks good. I see that you are still working on tests. Let me know when they are done. |
Codecov Report
@@ Coverage Diff @@
## master #624 +/- ##
==========================================
+ Coverage 60.57% 60.71% +0.13%
==========================================
Files 27 27
Lines 3792 3785 -7
==========================================
+ Hits 2297 2298 +1
+ Misses 1495 1487 -8
Continue to review full report at Codecov.
|
DonJayamanne
force-pushed
the
fixPathMappings
branch
from
568247e
to
a85a216
Compare
ptvsd/wrapper.py
Outdated
| 'WINDOWS_CLIENT', | ||
| platform.system() == 'Windows') | ||
| os_id = 'WINDOWS' if windows_client else 'UNIX' | ||
| default_os_type = 'WINDOWS' if sys.platform == 'win32' else 'UNIX' |
There was a problem hiding this comment.
sys.platform == 'win32' [](start = 39, length = 23)
platform.system()
| @@ -45,7 +45,8 @@ contact [[email protected]](mailto:[email protected]) with any additio | |||
| "Jinja", // Enables Jinja (Flask) Template debugging | |||
| "FixFilePathCase", // See FIX_FILE_PATH_CASE in wrapper.py | |||
| "DebugStdLib" // Whether to enable debugging of standard library functions | |||
| "WindowsClient" // Whether client OS is Windows or not | |||
| "WindowsClient" // Whether client OS is Windows | |||
| "UnixClient" // Whether client OS is Unix | |||
There was a problem hiding this comment.
UnixClient [](start = 13, length = 10)
This should be updated.
There was a problem hiding this comment.
It is, this is what VSC sends,
There was a problem hiding this comment.
This reverts commit 14982d9.
Fixes #610
@karthiknadig Please get this PR locally and test at your end.
I have tested from
Please test this specific scenario #610 (comment)
Note: I'm not sure
~/GITwill work, you might want to use absolute paths.I'll be working on system tests.