This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Removes ptvsd threads from the threads list. #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int19h
reviewed
Feb 9, 2018
ptvsd/wrapper.py
Outdated
| name = unquote(xml.thread['name']) | ||
| except KeyError: | ||
| name = None | ||
| if not (name and name.startswith('ptvsd.')): |
There was a problem hiding this comment.
Should we also be filtering out pydevd threads here, same as in the other place?
Also, let's refactor the check itself into a function, something like is_debugger_internal_thread.
There was a problem hiding this comment.
For some reason pydevd threads did not show up here, but you are right. I will refactor this as recommended.
int19h
reviewed
Feb 11, 2018
ptvsd/wrapper.py
Outdated
| @@ -455,6 +455,11 @@ def send_process_event(self, start_method): | |||
| } | |||
| self.send_event('process', **evt) | |||
|
|
|||
| def is_debugger_internal_thread(self, thread_name): | |||
| if thread_name: | |||
| return thread_name.startswith('pydevd.') or thread_name.startswith('ptvsd.') | |||
There was a problem hiding this comment.
This can all be combined in a single expression:
return thread_name and (thread_name.startswith('pydevd.') or thread_name.startswith('ptvsd.'))
int19h
approved these changes
Feb 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #27