Fill in some gaps in the project files. #4

ericsnowcurrently · 2018-01-09T18:36:11Z

This is an effort to establish a foundation for future work. In particular, I'm planning on the following in the near future:

add a variety of tests
set up CI (including a coverage check)
clean up lint errors

zooba · 2018-01-09T22:17:28Z

tests/__main__.py

+        args = ['discover',
+                '--start-directory', PROJECT_ROOT,
+                ] + args
+    return [sys.executable + ' -m unittest'] + args


Doesn't this command line just put the path to unittest/__main__.py in argv[0]?

Yeah, effectively. It's the way unittest.main() likes it though.

…epping (#1235) * Switch to json requests in wrapper * Add json handler for pause, continue, next, stepIn, and stepOut * Tweaks to get stuff working * Add pydevd tests for json requests * Address comments (#4)

Fix microsoft#3: Child processes aren't auto-killed reliably

ericsnowcurrently mentioned this pull request Jan 9, 2018

Fix flake8 failures. #5

Merged

ericsnowcurrently added 6 commits January 9, 2018 20:58

Add a tests package.

7fdd0b2

Add a __main__ for running the test suite.

58f3a0e

Add a make file for dev tasks.

3d6b05b

Add TravisCI support.

e3d1732

Do not hard-code Python 3.

dc00f36

Factor out convert_argv().

9a61a4e

ericsnowcurrently force-pushed the meta-cleanup branch from 5503d5f to 9a61a4e Compare January 9, 2018 20:58

ericsnowcurrently requested a review from int19h January 9, 2018 21:06

zooba approved these changes Jan 9, 2018

View reviewed changes

ericsnowcurrently merged commit 4cdd5f5 into microsoft:master Jan 9, 2018

ericsnowcurrently deleted the meta-cleanup branch January 9, 2018 22:21

fuzihaofzh mentioned this pull request Jul 23, 2019

Core dump when run few steps. #1617

Closed

fabioz pushed a commit to fabioz/ptvsd that referenced this pull request Jan 23, 2020

Merge pull request microsoft#4 from int19h/3

24718a4

Fix microsoft#3: Child processes aren't auto-killed reliably

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fill in some gaps in the project files. #4

Fill in some gaps in the project files. #4

ericsnowcurrently commented Jan 9, 2018

zooba Jan 9, 2018

ericsnowcurrently Jan 9, 2018

Fill in some gaps in the project files. #4

Fill in some gaps in the project files. #4

Conversation

ericsnowcurrently commented Jan 9, 2018

zooba Jan 9, 2018

Choose a reason for hiding this comment

ericsnowcurrently Jan 9, 2018

Choose a reason for hiding this comment