Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Enable build and sign on Windows #217

Merged
merged 7 commits into from
Mar 19, 2018
Merged

Enable build and sign on Windows #217

merged 7 commits into from
Mar 19, 2018

Conversation

zooba
Copy link
Member

@zooba zooba commented Mar 16, 2018

This script can be run to generate a semi-pure wheel that includes precompiled extension modules for 3.5 and 3.6, both 32-bit and 64-bit. (Python 3.5 is when Windows started using ABI suffix on extension modules - we can't replicate this as easily for earlier versions.) I already have an internal build definition using this that can also sign all the binaries as needed.

I also fixed #112 by changing how we build the extension modules (i.e. with the correct names). I'm also not quite sure why the default_return_value change became necessary, but it was, so I assume it was one of our patches?

@int19h
Copy link
Contributor

int19h commented Mar 17, 2018

@karthiknadig, can you take a look at default_return_value stuff?

@karthiknadig
Copy link
Member

@zooba default_return_value change was done to fix the conditional breakpoints in pydevd. It was this change that did that 63e93ec

@zooba
Copy link
Member Author

zooba commented Mar 18, 2018

Okay, I removed the parameter. Can you confirm that it should be returning False/None in this case?

@karthiknadig
Copy link
Member

It should return False, that makes the intent of returning there clearer.

@zooba
Copy link
Member Author

zooba commented Mar 19, 2018

Done. The else block of that function needs looking at too, as it doesn't return anything (and arguably if the condition is broken it should return True so that we break, right?).

But file it separately - we need this PR merged before we can build for today's bug bash.

@zooba zooba merged commit ae364f3 into microsoft:master Mar 19, 2018
@zooba zooba deleted the winbuild branch March 19, 2018 17:30
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cython speedup extension is not found
3 participants