This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Improve handling of daemon thread termination when terminating the debugee #140
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
int19h
reviewed
Feb 27, 2018
ptvsd/wrapper.py
Outdated
| def exit_handler(proc, server_thread): | ||
| proc.close() | ||
| if server_thread.is_alive(): | ||
| server_thread.join(0.1) |
There was a problem hiding this comment.
Let's increase this to something like a second - 100ms is just too easy to hit under load.
int19h
approved these changes
Feb 27, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #139
Two solutions here:
set_exitto notify theptvsd.Clientif it needs to exit (by initializing the__exitflag)