This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Remove 'yield' from some request handlers #1267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove 'yield' from some request handlers * Fix json notify request
int19h
approved these changes
Mar 27, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1266. We previously treated this as a notify (event) to pydevd, with the switch to json protocol this is now a request. If we wait for a response for request such as
continuerequest. The thread could begin and suspend immediately.This could be done with
pydevd_notify, notify calls don't expect a response. since requests like continue has a response this causes additional issue in the debugger where it fails to associate the response with a request, and crash.In this PR, I am replicating the same behavior as we had with
pydevd_notifyby usingpydevd_requestbut ignoring the response.