This repository has been archived by the owner on Aug 2, 2023. It is now read-only.
Adds extension module to setup.py #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the simplest way to build the pydevd extension when creating wheels.
However, I think we'd probably be better off using a more custom script for generating a single wheel with ABI tagged extension modules in it, as this will better suit us being able to embed a copy of the package in our tools with prebuilt extensions. We also need to code sign it, which is currently easier to do by building separately rather than integrating into the distutils flow (though this is possible).
But at least with this change anyone who installs ptvsd manually can have the extension module.