Skip to content
This repository has been archived by the owner on Aug 2, 2023. It is now read-only.

Ptvsd should handle disconnect request #120

Closed
karthiknadig opened this issue Feb 24, 2018 · 3 comments
Closed

Ptvsd should handle disconnect request #120

karthiknadig opened this issue Feb 24, 2018 · 3 comments
Labels

Comments

@karthiknadig
Copy link
Member

 1> [DebugAdapter] <--   E (exited): {"type": "event", "seq": 19, "event": "exited", "body": {"exitCode": 0}}
 1> [DebugAdapter] <--   E (terminated): {"type": "event", "seq": 20, "event": "terminated", "body": {}}
 1> [DebugAdapter] --> C (disconnect-14): {"command":"disconnect","arguments":{},"seq":14,"type":"request"}

we currently exit process after sending terminated event.

@DonJayamanne
Copy link
Contributor

Interestingly this this isn't causing an issue with VS Code. Ideally we should get some error such as The debug adapter exited unexpectedly.
@karthiknadig are you getting any error messages in VS (such as the one I've mentioned above)?

Either way, I'd consider this to be a show stopper for VS Code, as this (not ending debug session correctly) could lead to errors being displayed by VS Code.

@brettcannon
Copy link
Member

I agree w/ @DonJayamanne that this is probably a showstopper for releasing experimental.

@karthiknadig
Copy link
Member Author

@DonJayamanne yes, I get that error message. I filed this bug for that reason.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants