Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added support for security-group-id #541

Merged
merged 2 commits into from
Apr 28, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions create-environment/action.yml
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ inputs:
description: 'The ID of the Microsoft Teams team to create the Power Apps environment in.'
required: false

security-group-id:
description: 'Microsoft Entra ID Security Group ID to use when creating the environment.'
required: false

outputs:
environment-url:
description: 'URL of the freshly created environment'
Expand Down
4 changes: 2 additions & 2 deletions gulpfile.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -228,12 +228,12 @@ async function nugetInstallPortalPackages() {
}

async function nugetInstallLinux() {
await nugetInstall('CAP_ISVExp_Tools_Stable', PacInfo.LegacyLinuxPackage, PacInfo.PacPackageVersion, path.resolve(outdir, 'pac_linux'));
await nugetInstall('nuget.org', PacInfo.LegacyLinuxPackage, PacInfo.PacPackageVersion, path.resolve(outdir, 'pac_linux'));
await setExecuteFlag(path.resolve(outdir, 'pac_linux', 'tools', 'pac'));
}

async function nugetInstallWindows() {
await nugetInstall('CAP_ISVExp_Tools_Stable', PacInfo.PacPackageName, PacInfo.PacPackageVersion, path.resolve(outdir, 'pac'));
await nugetInstall('nuget.org', PacInfo.PacPackageName, PacInfo.PacPackageVersion, path.resolve(outdir, 'pac'));
}

async function restore() {
Expand Down
15 changes: 7 additions & 8 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@
"@actions/core": "^1.10.1",
"@actions/exec": "^1.1.1",
"@actions/io": "^1.1.3",
"@microsoft/powerplatform-cli-wrapper": "^0.1.118",
"@microsoft/powerplatform-cli-wrapper": "^0.1.120",
"date-fns": "^2.30.0",
"fs-extra": "^11.1.1",
"js-yaml": "^4.1",
Expand Down
1 change: 1 addition & 0 deletions src/actions/create-environment/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,7 @@ export async function main(): Promise<void> {
templates: parameterMap['templates'],
domainName: parameterMap['domain'],
teamId: parameterMap['team-id'],
securityGroupId: parameterMap['security-group-id'],
logToConsole: false,
}, runnerParameters, new ActionsHost());

Expand Down
1 change: 1 addition & 0 deletions src/test/createEnvironment.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ describe("create-environment tests", () => {
templates: { name: 'templates', required: false, defaultValue: undefined },
domainName: { name: 'domain', required: false, defaultValue: undefined },
teamId: {name:'team-id', required: false, defaultValue: undefined},
securityGroupId: {name:'security-group-id', required: false, defaultValue: undefined},
logToConsole: false,
}, runnerParameters, new ActionsHost());
});
Expand Down
Loading