Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dragging nodes to reorder positions #24

Merged
merged 7 commits into from
Aug 22, 2017
Merged

Dragging nodes to reorder positions #24

merged 7 commits into from
Aug 22, 2017

Conversation

zBritva
Copy link
Contributor

@zBritva zBritva commented Aug 22, 2017

No description provided.

Ilfat Galiev added 4 commits August 16, 2017 13:30
Dragging nodes
ff0a034 
# Conflicts:
#	src/visual.ts
Use persistProperties method to store settings;
e918b4d
Add field names to tooltip labels title.
dcd21f3 
Add scale of node position in resizing viewport
Code review
bf8e5e4
@msftclas
Copy link

@zBritva,
Thanks for your contribution as a Microsoft full-time employee or intern. You do not need to sign a CLA.
Thanks,
Microsoft Pull Request Bot

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 88.456% when pulling 42dff7d on zBritva:dragging_nodes into fe22ced on Microsoft:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 88.456% when pulling 42dff7d on zBritva:dragging_nodes into fe22ced on Microsoft:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 88.456% when pulling 2e41350 on zBritva:dragging_nodes into fe22ced on Microsoft:master.

ignatvilesov
ignatvilesov suggested changes Aug 22, 2017
View reviewed changes
Copy link
Contributor

@ignatvilesov ignatvilesov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please include a few unit tests in order to improve code coverage?

src/visual.ts Outdated
@@ -622,6 +644,11 @@ module powerbi.extensibility.visual {
SankeyDiagram.DefaultColourOfLink,
linksObjects[index]);

// linkSettings = this.getLinkSettings(
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this commented code

@coveralls
Copy link

Coverage Status

Coverage decreased (-4.8%) to 88.456% when pulling 4b4ff80 on zBritva:dragging_nodes into fe22ced on Microsoft:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 90.701% when pulling fd484dc on zBritva:dragging_nodes into fe22ced on Microsoft:master.

@coveralls
Copy link

Coverage Status

Coverage decreased (-2.5%) to 90.701% when pulling fd484dc on zBritva:dragging_nodes into fe22ced on Microsoft:master.

@coveralls
Copy link

coveralls commented Aug 22, 2017 •
edited
Loading

Coverage Status

Coverage decreased (-0.4%) to 92.857% when pulling 4eaccb1 on zBritva:dragging_nodes into fe22ced on Microsoft:master.

@ignatvilesov ignatvilesov merged commit c6188f6 into microsoft:master Aug 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ignatvilesov ignatvilesov ignatvilesov approved these changes

Assignees
No one assigned
Labels
cla-required
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zBritva @msftclas @coveralls @ignatvilesov