chore(expect): remove some dependencies on jest internals #8782
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgozman
approved these changes
Sep 8, 2021
| @@ -45,7 +37,7 @@ export async function toMatchText( | |||
| throw new Error(`${matcherName} must be called during the test`); | |||
| expectType(receiver, receiverType, matcherName); | |||
|
|
|||
| const matcherOptions: MatcherHintOptions = { | |||
There was a problem hiding this comment.
Should we copy this type definition for our own safety?
There was a problem hiding this comment.
It gets checked down below when we pass it in as an argument.
|
@dgozman, @JoelEinbinder, is this ready to merge? Anything I can do to help if not? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Simen suggests in jestjs/jest#11816, we can remove the
dependency on
jest-matcher-utilsby usingthis.utilsin our matchers. I cleanedup some other places were we use internal types that are not needed.
We still are requiring two unexported files:
expect/build/matchersandexpect/build/print