chore: report highlight parse error to debug controller #33984
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelfeldman
force-pushed
the
report_highlight_error_dc
branch
from
4944893 to
665bf6b
Compare
This comment has been minimized.
This comment has been minimized.
yury-s
approved these changes
Dec 12, 2024
| @@ -144,9 +147,17 @@ export class DebugController extends SdkObject { | |||
| } | |||
|
|
|||
| async highlight(params: { selector?: string, ariaTemplate?: string }) { | |||
| // Assert parameters validity. | |||
| if (params.selector) | |||
| unsafeLocatorOrSelectorAsSelector(this._sdkLanguage, params.selector, 'data-testid'); | |||
There was a problem hiding this comment.
debugControllerDispatcher will try catch and return the protocol error.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
force-pushed
the
report_highlight_error_dc
branch
from
665bf6b to
b6bced1
Compare
Test results for "tests 1"2 failed 9 flaky37248 passed, 650 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.