fix(recorder): do not leak when instantiated in snapshots #33240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `globalThis.setTimeout()` vs `InjectedScript.window.setTimeout()` makes a big difference. The former retains in the main Trace Viewer window, while the latter only retains in the snapshot iframe window, which is collected upon rendering a new snapshot.
Test results for "tests 1"1 failed 4 flaky36558 passed, 637 skipped Merge workflow run. |
pavelfeldman
approved these changes
Oct 23, 2024
dgozman
added a commit
to dgozman/playwright
that referenced
this pull request
Oct 24, 2024
…iated in snapshots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
globalThis.setTimeout()vsInjectedScript.window.setTimeout()makes a big difference. The former retains in the main Trace Viewer window, while the latter only retains in the snapshot iframe window, which is collected upon rendering a new snapshot.Regressed in #32637.
References #33086, #33219, #33141.