Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webkit): scroll mobile page with background-attachment: fixed #33048

Merged

Conversation

yury-s
Copy link
Member

@yury-s yury-s commented Oct 10, 2024

Fixes #31551
Fixes #23573

@yury-s yury-s added the CQ1 label Oct 10, 2024
@yury-s yury-s requested a review from mxschmitt October 10, 2024 18:28
@yury-s yury-s changed the title test: unskip scroll mobile page with background-attachment: fixed fix: unskip scroll mobile page with background-attachment: fixed Oct 10, 2024
@yury-s yury-s changed the title fix: unskip scroll mobile page with background-attachment: fixed fix(webkit): scroll mobile page with background-attachment: fixed Oct 10, 2024
Copy link
Contributor

Test results for "tests others"

20558 passed, 495 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

4 flaky ⚠️ [installation tests] › playwright-electron-should-work.spec.ts:21:5 › electron should work @package-installations-macos-latest
⚠️ [chromium-page] › page/page-event-request.spec.ts:138:3 › should report navigation requests and responses handled by service worker with routing @ubuntu-20.04-chromium-tip-of-tree
⚠️ [playwright-test] › ui-mode-test-update.spec.ts:202:5 › should update test locations @ubuntu-latest-node20-1
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

35874 passed, 619 skipped
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
16 failed
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:707:7 › cli codegen › should select with multiple attribute @webkit-headed-macos-14-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-headed-macos-14-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:707:7 › cli codegen › should select with multiple attribute @webkit-macos-13-large
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-macos-13-large
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:707:7 › cli codegen › should select with multiple attribute @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-macos-13-xlarge
❌ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames fit @webkit-macos-13-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:707:7 › cli codegen › should select with multiple attribute @webkit-macos-14-large
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-macos-14-large
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:707:7 › cli codegen › should select with multiple attribute @webkit-macos-14-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-macos-14-xlarge
❌ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames scale @webkit-macos-14-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:707:7 › cli codegen › should select with multiple attribute @webkit-macos-15-large
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-macos-15-large
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:707:7 › cli codegen › should select with multiple attribute @webkit-macos-15-xlarge
❌ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-macos-15-xlarge

44 flaky ⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:525:7 › cli codegen › should --test-id-attribute @chromium-headed-windows-latest
⚠️ [chromium-library] › library/selector-generator.spec.ts:587:5 › selector generator › should generate multiple: noId noText @chromium-headed-windows-latest
⚠️ [chromium-page] › page/page-drag.spec.ts:73:5 › Drag and drop › should work inside iframe @chromium-headed-windows-latest
⚠️ [chromium-library] › library/inspector/cli-codegen-3.spec.ts:171:7 › cli codegen › should generate frame locators (4) @chromium-macos-14-large
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-macos-14-xlarge
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @chromium-tip-of-tree-macos-13--headed
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:405:7 › cli codegen › should update hover model on action @chromium-tip-of-tree-ubuntu-20.04--headed
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:24:7 › cli codegen › should click @chromium-tip-of-tree-windows-latest--headed
⚠️ [chromium-page] › page/page-drag.spec.ts:290:5 › Drag and drop › should work with the helper method @chromium-tip-of-tree-windows-latest--headed
⚠️ [firefox-library] › library/signals.spec.ts:25:5 › should close the browser when the node process closes @firefox-beta-windows-latest
⚠️ [firefox-library] › library/capabilities.spec.ts:254:3 › requestFullscreen @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation @firefox-headed-macos-14-xlarge
⚠️ [firefox-library] › library/browsercontext-proxy.spec.ts:167:3 › should use proxy for second page @firefox-headed-windows-latest
⚠️ [firefox-library] › library/browsercontext-proxy.spec.ts:294:3 › should exclude patterns @firefox-headed-windows-latest
⚠️ [firefox-library] › library/client-certificates.spec.ts:442:3 › browser › should pass with matching certificates in pfx format @firefox-headed-windows-latest
⚠️ [firefox-library] › library/download.spec.ts:80:5 › download event › should work with Cross-Origin-Opener-Policy @firefox-headed-windows-latest
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:556:7 › cli codegen › should generate getByLabel without regex @firefox-headed-windows-latest
⚠️ [firefox-library] › library/trace-viewer.spec.ts:148:1 › should render network bars @firefox-headed-windows-latest
⚠️ [chromium-page] › page/page-set-input-files.spec.ts:147:3 › should upload large file @msedge-dev-windows-latest
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:43:3 › should poll on interval @tracing-firefox
⚠️ [webkit-library] › library/video.spec.ts:165:5 › screencast › should work with old options @tracing-webkit
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:611:7 › cli codegen › should select @webkit-headed-macos-14-xlarge
⚠️ [webkit-page] › page/workers.spec.ts:106:3 › should clear upon navigation @webkit-headed-ubuntu-20.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:484:7 › cli codegen › should emit single keyup on ArrowDown @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:249:7 › cli codegen › should handle dialogs @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/popup.spec.ts:115:3 › should inherit viewport size from browser context @webkit-headed-ubuntu-22.04
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:814:7 › cli codegen › should attribute navigation to click @webkit-headed-ubuntu-24.04
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:206:1 › should reset mouse position @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:56:7 › cli codegen › should double click @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:740:7 › cli codegen › should unselect with multiple attribute @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:494:7 › cli codegen › should fill tricky characters @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:437:7 › cli codegen › should generate getByTestId @webkit-headed-windows-latest
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:585:7 › cli codegen › should consume pointer events @webkit-headed-windows-latest
⚠️ [webkit-page] › page/page-request-fallback.spec.ts:239:5 › post data › should amend binary post data @webkit-macos-13-large
⚠️ [webkit-page] › page/selectors-react.spec.ts:40:7 › react17 › should work with multi-root elements (fragments) @webkit-macos-13-large
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames crop @webkit-macos-13-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames scale @webkit-macos-13-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames fit @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames crop @webkit-macos-14-xlarge
⚠️ [webkit-page] › page/page-request-continue.spec.ts:241:5 › post data › should amend longer post data @webkit-macos-14-xlarge
⚠️ [webkit-library] › library/browsertype-connect.spec.ts:606:5 › run-server › should save har @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames fit @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames crop @webkit-macos-15-xlarge
⚠️ [webkit-library] › library/tracing.spec.ts:410:14 › should produce screencast frames scale @webkit-macos-15-xlarge

242606 passed, 9572 skipped, 5 did not run
✔️✔️✔️

Merge workflow run.

@yury-s yury-s merged commit 82fe882 into microsoft:main Oct 10, 2024
100 of 108 checks passed
@yury-s yury-s deleted the wk-setFixedBackgroundsPaintRelativeToDocument branch October 10, 2024 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants