Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: generate self-signed certificates for socks proxy #32192

Merged
merged 5 commits into from
Aug 16, 2024

Conversation

mxschmitt
Copy link
Member

No description provided.

@mxschmitt mxschmitt marked this pull request as ready for review August 16, 2024 11:54

This comment has been minimized.

packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved

This comment has been minimized.

@mxschmitt mxschmitt added the CQ1 label Aug 16, 2024

This comment has been minimized.

Copy link
Contributor

Test results for "tests others"

17977 passed, 486 skipped
✔️✔️✔️

Merge workflow run.

packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Show resolved Hide resolved
packages/playwright-core/src/utils/crypto.ts Outdated Show resolved Hide resolved

This comment has been minimized.

@mxschmitt mxschmitt force-pushed the generate-self-signed-certificate branch from 3d25584 to cadb3fe Compare August 16, 2024 15:20

This comment has been minimized.

Copy link
Contributor

Test results for "tests 2"

2 fatal errors, not part of any test
17 failed
❌ [chromium-library] › library/browsertype-connect.spec.ts:867:7 › run-server › socks proxy › should proxy based on the pattern
❌ [chromium-library] › library/browsertype-connect.spec.ts:898:7 › run-server › socks proxy › should check proxy pattern on the client
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
❌ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:502:7 › cli codegen › should save assets via SIGINT
❌ [chromium-library] › library/inspector/cli-codegen-csharp.spec.ts:171:5 › should work with --save-har
❌ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:92:5 › should work with --save-har
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [chromium-library] › library/inspector/pause.spec.ts:380:5 › pause › should highlight on explore
❌ [chromium-library] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
❌ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
❌ [chromium-library] › library/browsertype-connect.spec.ts:838:7 › run-server › socks proxy › should proxy local.playwright requests
❌ [chromium-library] › library/logger.spec.ts:19:3 › should log @smoke
❌ [chromium-page] › page/page-screenshot.spec.ts:283:5 › page screenshot › should work for canvas
❌ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
❌ [webkit-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
❌ [webkit-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
❌ [webkit-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation

90 flaky ⚠️ [chromium-library] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium-library] › library/global-fetch-cookie.spec.ts:171:1 › should remove cookie with negative max-age
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:301:5 › launchServer › disconnected event should have browser as argument
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:23:5 › launch server › should work
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:43:5 › launch server › should work with wsPath
⚠️ [chromium-library] › library/chromium/chromium.spec.ts:151:15 › should close service worker together with the context
⚠️ [chromium-library] › library/defaultbrowsercontext-1.spec.ts:83:3 › should(not) block third party cookies
⚠️ [chromium-library] › library/defaultbrowsercontext-2.spec.ts:216:3 › should connect to a browser with the default page
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-javascript.spec.ts:87:5 › should save the codegen output to a file if specified
⚠️ [chromium-library] › library/inspector/cli-codegen-pytest.spec.ts:57:5 › should save the codegen output to a file if specified
⚠️ [chromium-library] › library/inspector/pause.spec.ts:22:3 › should resume when closing inspector
⚠️ [chromium-library] › library/page-clock.spec.ts:264:3 › stubTimers › replaces global performance.now
⚠️ [chromium-library] › library/page-clock.spec.ts:282:3 › stubTimers › replaces global performance.timeOrigin
⚠️ [chromium-library] › library/proxy.spec.ts:45:3 › should use proxy for second page
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1189:1 › should pick locator in iframe
⚠️ [chromium-library] › library/tracing.spec.ts:350:5 › should survive browser.close with auto-created traces dir
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [chromium-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [chromium-page] › page/page-click.spec.ts:230:3 › should click on checkbox input and toggle
⚠️ [chromium-page] › page/page-mouse.spec.ts:176:3 › should trigger hover state on disabled button
⚠️ [chromium-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:106:7 › cli codegen › should make a positioned click on a canvas
⚠️ [chromium-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [chromium-library] › library/chromium/oopif.spec.ts:260:3 › ElementHandle.boundingBox() should work
⚠️ [chromium-library] › library/inspector/cli-codegen-1.spec.ts:23:7 › cli codegen › should click
⚠️ [firefox-library] › library/capabilities.spec.ts:260:3 › requestFullscreen
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-page] › page/page-click.spec.ts:230:3 › should click on checkbox input and toggle
⚠️ [firefox-page] › page/page-fill.spec.ts:284:3 › should retry on invisible element
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:22:7 › cli codegen › should click locator.first
⚠️ [firefox-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [firefox-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:57:7 › cli codegen › should click locator.nth
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-mouse.spec.ts:147:3 › should select the text with mouse
⚠️ [firefox-library] › library/browsercontext-pages.spec.ts:58:3 › should not hang with touch-enabled viewports
⚠️ [firefox-library] › library/browsertype-connect.spec.ts:341:5 › run-server › should throw when calling waitForNavigation after disconnect
⚠️ [firefox-library] › library/capabilities.spec.ts:68:3 › should play video @smoke
⚠️ [firefox-library] › library/capabilities.spec.ts:174:3 › navigator.clipboard should be present
⚠️ [firefox-library] › library/capabilities.spec.ts:278:3 › should send no Content-Length header for GET requests with a Content-Type
⚠️ [firefox-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [firefox-library] › library/selector-generator.spec.ts:224:5 › selector generator › should chain text after parent
⚠️ [firefox-page] › page/page-click.spec.ts:97:3 › should click the 1x1 div
⚠️ [firefox-page] › page/page-dialog.spec.ts:59:3 › should dismiss the confirm prompt
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [firefox-page] › page/page-goto.spec.ts:147:3 › should work with Cross-Origin-Opener-Policy after redirect
⚠️ [firefox-library] › library/tracing.spec.ts:412:14 › should produce screencast frames fit
⚠️ [chromium-library] › library/browser.spec.ts:54:5 › should dispatch page.on(close) upon browser.close and reject evaluate
⚠️ [chromium-library] › library/browsercontext-fetch.spec.ts:1214:3 › should work with connectOverCDP
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:272:5 › run-server › disconnected event should be emitted when browser is closed or server is closed
⚠️ [chromium-library] › library/browsertype-connect.spec.ts:853:7 › run-server › socks proxy › should lead to the error page for forwarded requests when the connection is refused
⚠️ [chromium-library] › library/browsertype-launch-server.spec.ts:50:5 › launch server › should work when wsPath is missing leading slash
⚠️ [chromium-library] › library/chromium/tracing.spec.ts:21:3 › should output a trace
⚠️ [chromium-library] › library/defaultbrowsercontext-2.spec.ts:28:3 › should work in persistent context
⚠️ [chromium-library] › library/defaultbrowsercontext-2.spec.ts:236:3 › user agent is up to date
⚠️ [chromium-library] › library/downloads-path.spec.ts:63:5 › downloads path › should report downloads in downloadsPath folder
⚠️ [chromium-library] › library/har.spec.ts:82:3 › should have pages in persistent context
⚠️ [chromium-library] › library/inspector/cli-codegen-2.spec.ts:493:7 › cli codegen › should --save-trace
⚠️ [chromium-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [chromium-library] › library/logger.spec.ts:34:3 › should log context-level
⚠️ [chromium-library] › library/proxy.spec.ts:32:3 › should use proxy @smoke
⚠️ [chromium-library] › library/proxy.spec.ts:94:11 › should proxy local network requests › with other bypasses › loopback address
⚠️ [chromium-library] › library/proxy.spec.ts:126:3 › should authenticate
⚠️ [chromium-page] › page/page-mouse.spec.ts:166:3 › should trigger hover state
⚠️ [firefox-page] › page/frame-goto.spec.ts:46:3 › should continue after client redirect
⚠️ [webkit-library] › library/video.spec.ts:189:5 › screencast › should capture static page
⚠️ [webkit-library] › library/inspector/cli-codegen-1.spec.ts:553:7 › cli codegen › should select
⚠️ [webkit-library] › library/inspector/cli-codegen-test.spec.ts:88:5 › should work with --save-har
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1189:1 › should pick locator in iframe
⚠️ [webkit-library] › library/emulation-focus.spec.ts:202:12 › should trigger hover state concurrently
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:704:7 › cli codegen › should assert value on disabled select
⚠️ [webkit-page] › page/page-set-input-files.spec.ts:40:3 › should upload a folder
⚠️ [webkit-library] › library/browsercontext-viewport.spec.ts:145:12 › should drag with high dpi
⚠️ [webkit-library] › library/inspector/cli-codegen-2.spec.ts:518:7 › cli codegen › should fill tricky characters
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:415:7 › cli codegen › should generate getByPlaceholder
⚠️ [webkit-library] › library/inspector/cli-codegen-3.spec.ts:704:7 › cli codegen › should assert value on disabled select
⚠️ [webkit-library] › library/trace-viewer.spec.ts:686:1 › should preserve currentSrc
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [webkit-page] › page/page-mouse.spec.ts:211:3 › should tween mouse movement
⚠️ [webkit-page] › page/workers.spec.ts:243:3 › should support offline
⚠️ [webkit-library] › library/video.spec.ts:381:5 › screencast › should capture navigation
⚠️ [webkit-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [webkit-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [webkit-library] › library/browsercontext-reuse.spec.ts:50:1 › should reset serviceworker

230272 passed, 9801 skipped, 3 did not run
✔️✔️✔️

Merge workflow run.

Copy link
Contributor

Test results for "tests 1"

3 flaky ⚠️ [chromium-library] › library/trace-viewer.spec.ts:248:1 › should have network requests
⚠️ [firefox-page] › page/page-goto.spec.ts:182:3 › should properly cancel Cross-Origin-Opener-Policy navigation
⚠️ [chromium-library] › library/popup.spec.ts:264:3 › should not throw when click closes popup

30033 passed, 860 skipped
✔️✔️✔️

Merge workflow run.

@mxschmitt mxschmitt merged commit 743565e into microsoft:main Aug 16, 2024
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants