fix(client-certificates): when server does tls renegotiation #32155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test results for "tests 1"1 failed 1 flaky29801 passed, 765 skipped Merge workflow run. |
dgozman
approved these changes
Aug 14, 2024
mxschmitt
added a commit
that referenced
this pull request
Aug 14, 2024
…enegotiation Certain https servers like Microsoft IIS aka. TLS servers do the TLS renegotiation after the TLS handshake. This ends up in two `'secureConnect'` events due to an upstream Node.js bug: nodejs/node#54362 Drive-by: Move other listeners like `'close'` / `'end'` to `once()` as well. Relates #32004
This was referenced Aug 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Certain https servers like Microsoft IIS aka. TLS servers do the TLS renegotiation after the TLS handshake. This ends up in two
'secureConnect'events due to an upstream Node.js bug: nodejs/node#54362Drive-by: Move other listeners like
'close'/'end'toonce()as well.Relates #32004