chore: client certificates api review #31826
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Test results for "tests 1"8 flaky29043 passed, 688 skipped Merge workflow run. |
dgozman
approved these changes
Jul 23, 2024
| - `passphrase` ?<[string]> Passphrase for the private key (PEM or PFX). | ||
|
|
||
| An array of client certificates to be used. Each certificate object must have both `certPath` and `keyPath` or a single `pfxPath` to load the client certificate. Optionally, `passphrase` property should be provided if the private key is encrypted. If the certificate is valid only for specific URLs, the `url` property should be provided with a glob pattern to match the URLs that the certificate is valid for. | ||
| - `origin` <[string]> Glob pattern to match against the request origin that the certificate is valid for. |
There was a problem hiding this comment.
Suggested change
| - `origin` <[string]> Glob pattern to match against the request origin that the certificate is valid for. | |
| - `origin` <[string]> Glob pattern that matches origins requiring this certificate, for example `"https://*.example.com"`. |
How do I match example.com and *.example.com with a glob? Is glob the best pattern we can use here, given that we don't match the path?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.