Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: update some test conditions #31336

Merged
merged 1 commit into from
Jun 17, 2024
Merged

test: update some test conditions #31336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 5 additions & 6 deletions tests/page/page-drag.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,10 +18,12 @@ import type { ElementHandle, Route } from 'playwright-core';
import { test as it, expect } from './pageTest';
import { attachFrame } from '../config/utils';

it.skip(({ browserName, browserMajorVersion }) => browserName === 'chromium' && browserMajorVersion < 91);
it.fixme(({ headless, isLinux }) => isLinux && !headless, 'Stray mouse events on Linux headed mess up the tests.');
it.fixme(({ headless, isWindows, browserName }) => isWindows && !headless && browserName === 'webkit', 'WebKit win also send stray mouse events.');

it.describe('Drag and drop', () => {
it.skip(({ browserName, browserMajorVersion }) => browserName === 'chromium' && browserMajorVersion < 91);
it.skip(({ isAndroid }) => isAndroid, 'No drag&drop on Android.');
it.fixme(({ headless, isLinux }) => isLinux && !headless, 'Stray mouse events on Linux headed mess up the tests.');

it('should work @smoke', async ({ page, server }) => {
await page.goto(server.PREFIX + '/drag-n-drop.html');
Expand Down Expand Up @@ -258,9 +260,7 @@ it.describe('Drag and drop', () => {
expect(await page.$eval('#target', target => target.contains(document.querySelector('#source')))).toBe(true);
});

it('should be able to drag the mouse in a frame', async ({ page, server, isAndroid }) => {
it.fixme(isAndroid);

it('should be able to drag the mouse in a frame', async ({ page, server }) => {
await page.goto(server.PREFIX + '/frames/one-frame.html');
const eventsHandle = await trackEvents(await page.frames()[1].$('html'));
await page.mouse.move(30, 30);
Expand Down Expand Up @@ -336,7 +336,6 @@ it.describe('Drag and drop', () => {
});

it('should work if not doing a drag', async ({ page, isLinux, headless }) => {
it.fixme(isLinux && !headless, 'Stray mouse events on Linux headed mess up the tests.');
const eventsHandle = await trackEvents(await page.$('html'));
await page.mouse.move(50, 50);
await page.mouse.down();
Expand Down
2 changes: 1 addition & 1 deletion tests/page/page-request-intercept.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ it('should give access to the intercepted response body', async ({ page, server,

it('should intercept multipart/form-data request body', async ({ page, server, asset, browserName }) => {
it.info().annotations.push({ type: 'issue', description: 'https://github.com/microsoft/playwright/issues/14624' });
it.fail(browserName !== 'firefox');
it.fixme(browserName !== 'firefox');
await page.goto(server.PREFIX + '/input/fileupload.html');
const filePath = path.relative(process.cwd(), asset('file-to-upload.txt'));
await page.locator('input[type=file]').setInputFiles(filePath);
Expand Down
Loading